Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the problem with reloading pages with multiple "/" after using a relative base in the Vite config. Build did not generate the correct files to support paths with multiple "/" characters in nginx, so pages like "/alert/[id]" could not be manually accessed by typing the URL or by refreshing the page after navigating to it. Switching to hashHistory for routing fixes this problem by using hashRoutes, which are correctly handled by nginx. This adds a "/#/" to the front of all paths, changing the URL "http://localhost:3000/alerts" to "http://localhost:3000/#/alerts". When using a subpath like "alerta", it becomes "http://localhost:3000/alerta/#/alerts".